GitLab

This fixes the last build failure, which was due to the job's display name containing spaces.

"x86_64" is changed to "x64" as the latter appears to be the most common identifier for the architecture, at least for Windows.

Turns out environment variables cannot be exported globally:

"/.ci/azure-pipelines/main.yml (Line: 7, Col: 1): Unexpected value 'env'"

It has to be done for each step that makes use of the variable.

Furthermore if a variable is not defined on Azure, the expansion
$(MY_VARIABLE) does not resolve to an empty String (as is the case e.g.
in Bash) but this expression is then taken literally without any
expansion at all. Therefore we have to make sure that the
BUILD_NUMBER_TOKEN variable is always defined. Thus we define it in
main-pr.yml as for PRs we don't define it on Azure.

In order for these variables to not interfere with each other, the
variable name inside the scripts was prefixed with MUMBLE_

Turns out environment variables cannot be exported globally:

"/.ci/azure-pipelines/main.yml (Line: 7, Col: 1): Unexpected value 'env'"

It has to be done for each step that makes use of the variable.

Furthermore if a variable is not defined on Azure, the expansion
$(MY_VARIABLE) does not resolve to an empty String (as is the case e.g.
in Bash) but this expression is then taken literally without any
expansion at all. Therefore we have to make sure that the
BUILD_NUMBER_TOKEN variable is always defined. Thus we define it in
main-pr.yml as for PRs we don't define it on Azure.

In order for these variables to not interfere with each other, the
variable name inside the scripts was prefixed with MUMBLE_

These no longer exist in contemporary icon themes like Adwaita.

Per https://developer.gnome.org/gtk3/stable/gtk3-Stock-Items.html
and https://specifications.freedesktop.org/icon-naming-spec/latest/ar01s04.html

558000 = 510000 (Opus) + 9600 (position) + 38400 (TCP overhead)

Closes #3895

Closes https://github.com/mumble-voip/mumble/issues/3895

DOCS(dev): Added a tip linking to faq part of building specific versions/commits to "build-instructions/README.md"
Signed-off-by: Tobias Gerold <tobias@g3ro.eu>

DOCS(dev): Added instructions for building specific versions/commits to "build-instructions/faq.md".
Signed-off-by: Tobias Gerold <tobias@g3ro.eu>
Co-authored-by: Robert Adam <dev@robert-adam.de>

The following icons were added (with a description) to Qt's "What's
this?" help system:

- padlocks (#3929)
- talking state for locally muted users (#4322)
- listener symbol (#4011)

Fixes #4686

We used mumble-vcpkg while the get script was still being implemented in a separate repository.
When we integrated it in this repository in 2f45772c it was already, and still is, using vcpkg.

Scanning directory './src'...
Scanning directory './src/mumble'...
Updating 'src/mumble/mumble_en.ts'...
    Found 1925 source text(s) (4 new and 1921 already existing)

We used mumble-vcpkg while the get script was still being implemented in a separate repository.
When we integrated it in this repository in 2f45772c it was already, and still is, using `vcpkg`.

Clients < 1.4.0 don't know about the new ChannelListener feature and
thus there is no indication in the UI for them. In order to make sure
that users know that they could potentially be listened to without
seeing anything in the UI, a warning message was introduced in #4097.

There was an error in the implementation however causing this warning to
not be sent by the server if there are no explicit limits on the amount
of channel listeners via the server configuration.

The bug was that "no limit" was expressed as -1 but the check for
whether these features are enabled checked for > 0. The fix is simply to
check for != 0 instead.

Fixes #4687

With the introduction of #3929 a channel's description would not be
accessible by clicking on the comment icon next to the channel's name
but rather by clicking to the lock icon to its right (if there was one).
This was due to some implicit assumptions about the comment icon's
position in the code that is responsible for showing the description.

Thus the fix was simply to let that part of the code account for the
possible new icon as well.

Fixes #4685

The following icons were added (with a description) to Qt's "What's
this?" help system:
- padlocks (#3929)
- talking state for locally muted users (#4322)
- listener symbol (#4011)

Fixes #4686

Clients < 1.4.0 don't know about the new ChannelListener feature and
thus there is no indication in the UI for them. In order to make sure
that users know that they could potentially be listened to without
seeing anything in the UI, a warning message was introduced in #4097.

There was an error in the implementation however causing this warning to
not be sent by the server if there are no explicit limits on the amount
of channel listeners via the server configuration.

The bug was that "no limit" was expressed as -1 but the check for
whether these features are enabled checked for > 0. The fix is simply to
check for != 0 instead.

Fixes #4687

With the introduction of #3929 a channel's description would not be
accessible by clicking on the comment icon next to the channel's name
but rather by clicking to the lock icon to its right (if there was one).
This was due to some implicit assumptions about the comment icon's
position in the code that is responsible for showing the description.

Thus the fix was simply to let that part of the code account for the
possible new icon as well.

Fixes #4685
Co-Authored-By: Davide Beatrici <git@davidebeatrici.dev>

BUILD_NUMBER_TOKEN has to be manually exported because it's a secret variable: https://docs.microsoft.com/en-us/azure/devops/pipelines/process/variables?view=azure-devops&tabs=yaml%2Cbatch#secret-variables

Also, the version sent to our endpoint has to be different for each job, we want the build number to increase a single time for each pipeline.

27471118 introduced support for the 4th part (build/tweak) of the version, however:

1. It didn't replace all instances of MUMBLE_VERSION_STRING with MUMBLE_VERSION.
2. It accidentally replaced MUMBLE_VERSION_STRING with MUMBLE_RELEASE_ID in MumbleVersion::get()'s signature.
3. It didn't update the regex expression in MumbleVersion::get() to support 4 digits.

This commit fixes all issues listed above.

Scanning directory './src'...
Scanning directory './src/mumble'...
Updating 'src/mumble/mumble_en.ts'...
    Found 1927 source text(s) (7 new and 1920 already existing)
    Removed 1 obsolete entries

Display a notice message and disable the input device combo box if mic
permission wasn't granted. Currently support CoreAudio and WASAPI.

This commit created a `isMicrophoneAccessDeniedByOS` function inside
each AudioInputRegistrar, unified the permission check interface for both
CoreAudio and WASAPI.

This commit utilized the internal permission check function to examine
if the user has granted mumble the microphone permission when initializing
CoreAudioInput backend. If the user hasn't granted the permission, it will
make a request through macOS's interface. If being denied, a warning message
will appear in the chat log.

This commit addressed #4547 and #4580. However, self-compiled unsigned
mumble binary still cannot access microphone because this is denied by
Apple's policy. The workaround is to start mumble binary from a terminal,
which is properly signed (e.g. the Terminal app pre-installed).

Implement #4547 and #4580.

The following changes were performed:
- Modify function to accept a string array param
- Add mdnsresponder to the packages array
- Remove individual package installs affected by previous --clean-after-build issue
- Remove iterator that installs packages independently
- Remove unneeded double quotes for variables
- Remove opus as it is supplied via submodule

Merge pull request #4678: CI(azure): Show translation difference if assert no translation test failed

Translation test failed on #4676 even if update translation script run on some OS (my macOS 10.15).

This commit aims to provide more information on translation changes when this test failed.

Provide more information on translation changes.

We want the build number to increase a single time for each pipeline.

https://docs.microsoft.com/en-us/azure/devops/pipelines/process/variables?view=azure-devops&tabs=yaml%2Cbatch#secret-variables

This commit:

- Adds null checks and error messages for "--arch" and "--version" to WixSharp projects.

- Sets cabinet file name to "Mumble.cab", for consistency with our previous installers.

- Cleans up ClientInstaller.

- Fixes regex patterns for string input safety and to simplify conditions.