This project is mirrored from https://github.com/mumble-voip/mumble. Pull mirroring updated .
  1. 24 Jan, 2021 1 commit
  2. 23 Jan, 2021 1 commit
  3. 22 Jan, 2021 4 commits
    • Robert Adam's avatar
      Merge pull request #4711: CI(azure): Export BUILD_NUMBER_TOKEN correctly · 4b533dce
      Robert Adam authored
      Turns out environment variables cannot be exported globally:
      
      "/.ci/azure-pipelines/main.yml (Line: 7, Col: 1): Unexpected value 'env'"
      
      It has to be done for each step that makes use of the variable.
      
      Furthermore if a variable is not defined on Azure, the expansion
      $(MY_VARIABLE) does not resolve to an empty String (as is the case e.g.
      in Bash) but this expression is then taken literally without any
      expansion at all. Therefore we have to make sure that the
      BUILD_NUMBER_TOKEN variable is always defined. Thus we define it in
      main-pr.yml as for PRs we don't define it on Azure.
      
      In order for these variables to not interfere with each other, the
      variable name inside the scripts was prefixed with MUMBLE_
      4b533dce
    • Davide Beatrici's avatar
      CI(azure): Fix usage of BUILD_NUMBER_TOKEN · 5d8d17a4
      Davide Beatrici authored
      Turns out environment variables cannot be exported globally:
      
      "/.ci/azure-pipelines/main.yml (Line: 7, Col: 1): Unexpected value 'env'"
      
      It has to be done for each step that makes use of the variable.
      
      Furthermore if a variable is not defined on Azure, the expansion
      $(MY_VARIABLE) does not resolve to an empty String (as is the case e.g.
      in Bash) but this expression is then taken literally without any
      expansion at all. Therefore we have to make sure that the
      BUILD_NUMBER_TOKEN variable is always defined. Thus we define it in
      main-pr.yml as for PRs we don't define it on Azure.
      
      In order for these variables to not interfere with each other, the
      variable name inside the scripts was prefixed with MUMBLE_
      5d8d17a4
    • Davide Beatrici's avatar
    • Robert Adam's avatar
      Merge pull request #4707: DOCS: fixed typos · 0b352ebe
      Robert Adam authored
      0b352ebe
  4. 21 Jan, 2021 1 commit
  5. 19 Jan, 2021 1 commit
  6. 18 Jan, 2021 2 commits
  7. 17 Jan, 2021 5 commits
  8. 16 Jan, 2021 1 commit
  9. 15 Jan, 2021 4 commits
  10. 14 Jan, 2021 5 commits
    • Robert Adam's avatar
      Merge pull request #4689: FIX(server): Older clients not being warned about ChannelListener · c8e8a84f
      Robert Adam authored
      Clients < 1.4.0 don't know about the new ChannelListener feature and
      thus there is no indication in the UI for them. In order to make sure
      that users know that they could potentially be listened to without
      seeing anything in the UI, a warning message was introduced in #4097.
      
      There was an error in the implementation however causing this warning to
      not be sent by the server if there are no explicit limits on the amount
      of channel listeners via the server configuration.
      
      The bug was that "no limit" was expressed as -1 but the check for
      whether these features are enabled checked for > 0. The fix is simply to
      check for != 0 instead.
      
      Fixes #4687
      c8e8a84f
    • Robert Adam's avatar
      Merge pull request #4688: FIX(client,ui): Channel description via lock icon · 48cd0223
      Robert Adam authored
      With the introduction of #3929 a channel's description would not be
      accessible by clicking on the comment icon next to the channel's name
      but rather by clicking to the lock icon to its right (if there was one).
      This was due to some implicit assumptions about the comment icon's
      position in the code that is responsible for showing the description.
      
      Thus the fix was simply to let that part of the code account for the
      possible new icon as well.
      
      Fixes #4685
      48cd0223
    • Robert Adam's avatar
      FEAT(client): Add new icons to "What's this?" · 367c99c2
      Robert Adam authored
      The following icons were added (with a description) to Qt's "What's
      this?" help system:
      - padlocks (#3929)
      - talking state for locally muted users (#4322)
      - listener symbol (#4011)
      
      Fixes #4686
      367c99c2
    • Robert Adam's avatar
      FIX(server): Older clients not being warned about ChannelListener · e3871336
      Robert Adam authored
      Clients < 1.4.0 don't know about the new ChannelListener feature and
      thus there is no indication in the UI for them. In order to make sure
      that users know that they could potentially be listened to without
      seeing anything in the UI, a warning message was introduced in #4097.
      
      There was an error in the implementation however causing this warning to
      not be sent by the server if there are no explicit limits on the amount
      of channel listeners via the server configuration.
      
      The bug was that "no limit" was expressed as -1 but the check for
      whether these features are enabled checked for > 0. The fix is simply to
      check for != 0 instead.
      
      Fixes #4687
      e3871336
    • Robert Adam's avatar
      FIX(client,ui): Channel description via lock icon · 0afab2bd
      Robert Adam authored
      With the introduction of #3929 a channel's description would not be
      accessible by clicking on the comment icon next to the channel's name
      but rather by clicking to the lock icon to its right (if there was one).
      This was due to some implicit assumptions about the comment icon's
      position in the code that is responsible for showing the description.
      
      Thus the fix was simply to let that part of the code account for the
      possible new icon as well.
      
      Fixes #4685
      Co-Authored-By: default avatarDavide Beatrici <git@davidebeatrici.dev>
      0afab2bd
  11. 13 Jan, 2021 3 commits
  12. 12 Jan, 2021 5 commits
  13. 11 Jan, 2021 3 commits
  14. 10 Jan, 2021 4 commits